jenkins-bot [Wed, 29 Mar 2017 20:48:46 +0000 (20:48 +0000)]
Merge "Update OOjs UI to v0.20.1"
jenkins-bot [Wed, 29 Mar 2017 20:39:07 +0000 (20:39 +0000)]
Merge "EditPage: Refactor getCheckboxes() to allow changing the format"
jenkins-bot [Wed, 29 Mar 2017 20:06:58 +0000 (20:06 +0000)]
Merge "ResourceLoaderImage: Correctly ignore 'deprecated' key"
jenkins-bot [Wed, 29 Mar 2017 20:06:03 +0000 (20:06 +0000)]
Merge "Special:RecentChangesLinked show "no results" message"
Bartosz Dziewoński [Sat, 25 Mar 2017 20:41:03 +0000 (21:41 +0100)]
EditPage: Refactor getCheckboxes() to allow changing the format
getCheckboxes() directly generated the HTML for the
"This is a minor edit" and "Watch this page" checkboxes,
and allowed extensions to add more HTML checkboxes (and
modify existing ones) using the 'EditPageBeforeEditChecks'
hook. This prevents us from ever changing the format of
the HTML (e.g. to use OOUI checkboxes).
Introduce new method getCheckboxesDefinition(), which
generates the checkboxes in a machine-readable format,
with a new hook 'EditPageGetCheckboxesDefinition'.
Rewrite getCheckboxes() in terms of that. The old hook
'EditPageBeforeEditChecks' is now deprecated.
Change-Id: I3dbe973dcac6cba0c3a1ac5d983cafcfb49d833c
Translation updater bot [Wed, 29 Mar 2017 19:57:26 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I18df74d64336e8539b7ac85fc6a456759d283e9c
Volker E [Tue, 28 Mar 2017 23:25:58 +0000 (16:25 -0700)]
Update OOjs UI to v0.20.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.20.1
Depends-On: I9b50eee459085eaa00819cbabe340ac442a332bd
Change-Id: I9b50eee459085eaa00819cbabe340ac442a332db
jenkins-bot [Wed, 29 Mar 2017 19:39:18 +0000 (19:39 +0000)]
Merge "mw.widgets.Complex*: Add setDisabled"
Roan Kattouw [Wed, 29 Mar 2017 18:44:22 +0000 (14:44 -0400)]
ResourceLoaderImage: Correctly ignore 'deprecated' key
It turns out that 'resources/lib/oojs-ui/themes/mediawiki/Moved since v0.20.1, use from the 'interactions' pack instead.'
is not usually an existing file, and doesn't have the extension '.svg'.
Not sure why this didn't break earlier.
Bonus: Add module name to exceptions to make these errors easier
to track down.
Bonus #2: Use the post-expansion, not pre-expansion, definition everywhere
to avoid confusion when debugging.
Change-Id: I0325d4dab5658fd29c3c33fd3e762834b53d1b5d
jenkins-bot [Wed, 29 Mar 2017 18:29:11 +0000 (18:29 +0000)]
Merge "Move DBConnRef/MaintainableDBConnRef to Rdbms namespace"
Aaron Schulz [Wed, 29 Mar 2017 16:15:50 +0000 (09:15 -0700)]
Move DBConnRef/MaintainableDBConnRef to Rdbms namespace
Change-Id: I7ca6b40f973b2aae83747de92e280ded222c87e3
Stephane Bisson [Wed, 29 Mar 2017 16:36:49 +0000 (12:36 -0400)]
Special:RecentChangesLinked show "no results" message
Bug: T160482
Change-Id: I26743928b359ad052ff53bde281f0479cbe68a99
jenkins-bot [Wed, 29 Mar 2017 16:23:38 +0000 (16:23 +0000)]
Merge "Make Title::getFirstRevision() ignore the rev_timestamp index"
Roan Kattouw [Tue, 28 Mar 2017 15:34:56 +0000 (11:34 -0400)]
Make Title::getFirstRevision() ignore the rev_timestamp index
We want the page_timestamp index to be used in this case, but sometimes
the rev_timestamp is chosen which leads to bad performance.
Also update WikiPage::getOldestRevision() which uses the exact same query.
I'll implement one in terms of the other in a follow-up commit.
Bug: T159319
Change-Id: I7c5c0a9b1af99ce2b5f4bdcc99710d8400ca8bcf
jenkins-bot [Wed, 29 Mar 2017 14:11:40 +0000 (14:11 +0000)]
Merge "Allow filtering by username on Special:NewFiles"
jenkins-bot [Wed, 29 Mar 2017 06:44:49 +0000 (06:44 +0000)]
Merge "HttpFunctions: Increase code coverage"
jenkins-bot [Wed, 29 Mar 2017 00:46:59 +0000 (00:46 +0000)]
Merge "Move IDatabase/IMaintainableDatabase to Rdbms namespace"
jenkins-bot [Wed, 29 Mar 2017 00:46:52 +0000 (00:46 +0000)]
Merge "Defer calling ChronologyProtector::initLB() until connecting"
Timo Tijhof [Wed, 29 Mar 2017 00:21:15 +0000 (17:21 -0700)]
HttpFunctions: Increase code coverage
* Complete coverage for Http::getProxy().
* Remove bogus @covers tag on data provider, and add the
relevant MWHttpRequest::getFinalUrl to the test instead.
* Convert test to use dataProvider and add missing test cases
to increase getFinalUrl() test coverage to 100%.
* Minor clean up in getFinalUrl to consistently use early-return
for all cases, not just for relative 'domain' and 'isset-host'
cases. Without this coverage actually couldn't reach 100% due
to the remainder of the empty else branch never being reached
(CRAP: "Redundant 'else' after 'return'")
Change-Id: I775d95965dc23a1e6c4c62ed84f9da64b6c72135
Aaron Schulz [Fri, 24 Mar 2017 00:30:29 +0000 (17:30 -0700)]
Defer calling ChronologyProtector::initLB() until connecting
Bug: T160678
Change-Id: Id51c2854f38d9e4697e52776168b16996e9152e4
jenkins-bot [Tue, 28 Mar 2017 23:32:06 +0000 (23:32 +0000)]
Merge "Deprecate "Avoid page_touched update for HTTP GET action=purge requests""
Aaron Schulz [Fri, 10 Feb 2017 18:09:05 +0000 (10:09 -0800)]
Move IDatabase/IMaintainableDatabase to Rdbms namespace
Change-Id: If7e8a8ff574661fd827de8bcec11d2c39a687300
Timo Tijhof [Tue, 28 Mar 2017 21:34:18 +0000 (14:34 -0700)]
resourceloader: Avoid deprecated getModifiedHash() in SkinModule
Use getDefinitionSummary instead, which uses a single serialisation
pass instead of requiring every stage to be a string. This way
we don't need to call json_encode and md5() multiple times.
getModifiedHash() was deprecated in MediaWiki 1.26.
Change-Id: If9e9caa3d12976c99543ad53ab280355b70acb17
jenkins-bot [Tue, 28 Mar 2017 21:24:42 +0000 (21:24 +0000)]
Merge "Catch errors in more cases inside MediaWiki::triggerJobs()"
jenkins-bot [Tue, 28 Mar 2017 21:16:57 +0000 (21:16 +0000)]
Merge "ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget"
jenkins-bot [Tue, 28 Mar 2017 21:16:52 +0000 (21:16 +0000)]
Merge "Rename CategorySelector to CategoryMultiselectWidget"
Translation updater bot [Tue, 28 Mar 2017 19:58:48 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie34e238728bbf19d934f98e3a6d8e847f9be60a5
jenkins-bot [Tue, 28 Mar 2017 19:56:34 +0000 (19:56 +0000)]
Merge "hidemyself/hidebyothers: Use rc_user_text since there is an index"
Matthew Flaschen [Mon, 27 Mar 2017 21:06:01 +0000 (17:06 -0400)]
hidemyself/hidebyothers: Use rc_user_text since there is an index
hidebyothers was extremely slow (on large data sets) due to the
lack of an index on rc_user. To fix this, changed to use rc_user_text.
hidemyself seems to be fine (assuming normal usage patterns), but
to avoid edge cases and ensure full coverage, it's been changed as
well.
I'll inquire about adding an index for this.
Bug: T161557
Change-Id: I61efe11de12e8ab6c01e8d913cdeda471132a6ee
jenkins-bot [Tue, 28 Mar 2017 15:09:28 +0000 (15:09 +0000)]
Merge "Change Title::getPreviousRevisionID (and next) to ignore PRIMARY"
jenkins-bot [Tue, 28 Mar 2017 14:19:21 +0000 (14:19 +0000)]
Merge "MWHttpRequest: optionally add original request data"
Prateek Saxena [Fri, 24 Mar 2017 10:25:56 +0000 (15:55 +0530)]
ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget
...instead of CategorySelector
Bug: T161285
Change-Id: Icd9bb162caa63c5a43f90e31818fc1432c6d66be
Prateek Saxena [Fri, 24 Mar 2017 09:55:37 +0000 (15:25 +0530)]
Rename CategorySelector to CategoryMultiselectWidget
For consistency.
Bug: T161285
Change-Id: I7c9e0089ba6b77f4bc73e14b989630487f6f3174
jenkins-bot [Tue, 28 Mar 2017 08:04:18 +0000 (08:04 +0000)]
Merge "Add tests for CSSMin::getMimeType"
jenkins-bot [Tue, 28 Mar 2017 07:59:45 +0000 (07:59 +0000)]
Merge "resourceloader: Optimise getMimeType() for common case"
Timo Tijhof [Sat, 25 Mar 2017 19:38:09 +0000 (12:38 -0700)]
build: Make Travis CI 'Postgres' build non-voting
This will make it easier to detect regressions by not making all
builds marked as fail, but only if one of the other three fails.
Mute the known failure from Postgres by adding it to an allow_failures
section. It'll still run every commit, but is non-voting.
To be re-enabled once T75174 is fixed.
Bug: T75176
Change-Id: I2ea415edd308f2a012ef240d562c0073f15b9118
jenkins-bot [Mon, 27 Mar 2017 22:18:00 +0000 (22:18 +0000)]
Merge "RCFilters UI: Only show full coverage message if item isn't highlighted"
Aaron Schulz [Mon, 27 Mar 2017 20:26:13 +0000 (13:26 -0700)]
Catch errors in more cases inside MediaWiki::triggerJobs()
This catches things like "DB is read-only" when doing pop()/ack() from the
job table with sqlite.
Also spun off some code to new trigger*Jobs() methods for readability.
Bug: T88312
Change-Id: I2a09248e40867684d48e6739da5e4a90581fa6ce
Translation updater bot [Mon, 27 Mar 2017 20:56:37 +0000 (22:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9a519432d6d8d818987818a6d7c07d1fdebe2f81
jenkins-bot [Mon, 27 Mar 2017 20:41:37 +0000 (20:41 +0000)]
Merge "rcfilters: Avoid $.type()"
Stephane Bisson [Mon, 27 Mar 2017 19:34:39 +0000 (15:34 -0400)]
rcfilters: Avoid $.type()
Followup to I9a0c5e40b813e075ec33eea882b625dc43a15df6
Replace $.type() with typeof or Array.isArray
Change-Id: I4f0f717c345ab1279b626b158b0ed6ada056bbc1
Gergő Tisza [Sat, 25 Mar 2017 23:05:44 +0000 (23:05 +0000)]
MWHttpRequest: optionally add original request data
Bug: T161029
Change-Id: I16a2eec46ae9e0e242fe740be20e39a2422dc867
jenkins-bot [Mon, 27 Mar 2017 19:16:48 +0000 (19:16 +0000)]
Merge "Add array typehint to 2 DatabaseUpdater methods"
jenkins-bot [Mon, 27 Mar 2017 19:11:19 +0000 (19:11 +0000)]
Merge "Add a tracking category when a template loop is detected"
jenkins-bot [Mon, 27 Mar 2017 18:37:53 +0000 (18:37 +0000)]
Merge "Add support for Atikamekw"
jenkins-bot [Mon, 27 Mar 2017 18:32:00 +0000 (18:32 +0000)]
Merge "EditPage: Minor code style improvements"
Brad Jorsch [Wed, 1 Feb 2017 15:12:14 +0000 (10:12 -0500)]
Deprecate "Avoid page_touched update for HTTP GET action=purge requests"
This reverts most of commit
c84ba4d86420d7af918e572e2cd4613d7be185b3.
The changes made there are no longer needed, and nothing in Gerrit seems
to have started using them since they were added.
The added constants in WikiPage, WikiPage::getLastPurgeTimestamp(), and
Article::getLastPurgeTimestamp() are deprecated, useless, and unused,
but not removed yet since they snuck into 1.28 so we can't revert them
without a deprecation period. Sigh.
Bug: T145649
Change-Id: I526fd4e004bee84c831a4cee71e44e92ee73480b
Sébastien Santoro [Wed, 8 Jun 2016 23:52:04 +0000 (23:52 +0000)]
Add support for Atikamekw
Language code: atj
Bug: T137376
Change-Id: Ieb9b6bcd09aedbf520b384a6572f96d7db1eca18
Translation updater bot [Sun, 26 Mar 2017 19:56:00 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I52bcb35ec9bae29b0adf6d745ad63706fd69e011
Thiemo Mättig [Sun, 26 Mar 2017 16:08:06 +0000 (18:08 +0200)]
Add tests for CSSMin::getMimeType
Direct follow up for I1768646. The tests are copied from my patch
If985f33, with one important difference: Now the file extension always
wins. Mismatches are not fixed any more by this code. This is intended.
See the discussion at I1768646.
Change-Id: I06b873a808d58ae7e53272765b156ac0fa293c2c
Bartosz Dziewoński [Sat, 25 Mar 2017 14:32:32 +0000 (15:32 +0100)]
EditPage: Minor code style improvements
Mostly whitespace fixes. Avoiding some temporary variables.
Change-Id: I65f31f2bdd01ab677caff5f628222993ad719c2f
jenkins-bot [Sat, 25 Mar 2017 13:18:16 +0000 (13:18 +0000)]
Merge "build: karma now reports with mocha formatter"
jenkins-bot [Sat, 25 Mar 2017 03:56:12 +0000 (03:56 +0000)]
Merge "Ensure we use mw.now() instead of 'new Date' for relative measurement"
Timo Tijhof [Sat, 25 Mar 2017 03:37:23 +0000 (20:37 -0700)]
Ensure we use mw.now() instead of 'new Date' for relative measurement
'new Date' is subject to clock drift etc.
mw.now() uses performance.now() when available, which will always
increase at a constant rate independent of the system clock.
Change-Id: Ib653103bf6116544f35c930fb33421f1bb362c7d
Timo Tijhof [Sat, 25 Mar 2017 03:20:44 +0000 (20:20 -0700)]
resourceloader: Optimise getMimeType() for common case
About 0.74% of load.php is spent in CSSMin::getMimeType/finfo_file.
We don't apply this to user-generated content of external urls,
only local files in version control. And in terms of correctness,
we don't support misleading file names, so it's not a problem that
a foo.png containing XML/SVG content would get the wrong mime-type
when base64 embedding it in CSS.
Change-Id: I17686467c897984117671098e94db8732446dc75
Subramanya Sastry [Sat, 25 Mar 2017 02:54:07 +0000 (21:54 -0500)]
Tweak CSS for Parsoid <figure>s
* These tweaks give us zero pixel diffs for images (when the
magnify icon is hidden) outside galleries.
Change-Id: Icd5a280a13162401f0bced93a91f9dfa45a3a481
jenkins-bot [Sat, 25 Mar 2017 01:50:56 +0000 (01:50 +0000)]
Merge "Decode '0'-valued user options to integer 0"
jenkins-bot [Sat, 25 Mar 2017 01:14:17 +0000 (01:14 +0000)]
Merge "Add @since tags to WikiRevision"
jenkins-bot [Sat, 25 Mar 2017 01:13:53 +0000 (01:13 +0000)]
Merge "Add missing @group Database tags in tests"
jenkins-bot [Sat, 25 Mar 2017 01:03:20 +0000 (01:03 +0000)]
Merge "Check for string initialization in lcfirst() for HHVM 3.18"
addshore [Thu, 16 Mar 2017 09:51:54 +0000 (09:51 +0000)]
Add @since tags to WikiRevision
Change-Id: I02005184d2cb3fa50aa0a51221b40e7c621219d2
Timo Tijhof [Sat, 25 Mar 2017 00:33:40 +0000 (17:33 -0700)]
qunit: Remove experimental CompletenessTest feature
The CompletenessTest was my attempt at measuring a basic code coverage
using run-time inspection instead of static instrumentation.
Originally added in
540419a82e5a5 (2010; MediaWiki 1.17).
It was never finished, remained fairly buggy and disabled by default.
It is also no longer used anywhere.
Bug: T155194
Change-Id: I26e7466426dddb43596f402e31005a89060c1b96
Translation updater bot [Fri, 24 Mar 2017 20:53:45 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I52ddf38b7a669842ed8157f5929cf4519ff9a57a
Moriel Schottlender [Fri, 24 Mar 2017 17:17:37 +0000 (10:17 -0700)]
RCFilters UI: Only show full coverage message if item isn't highlighted
Bug: T161273
Change-Id: If62bbab3e12fc3d9e83f9452723a9b2d6b75854a
Antoine Musso [Fri, 24 Mar 2017 14:19:36 +0000 (15:19 +0100)]
Check for string initialization in lcfirst() for HHVM 3.18
HHVM 3.18 emits a notice when attempting to access the first offset of
an empty string. We had that fixed for ucfirst() in
3605066c96. This is
the same for lcfirst().
Bug: T161095
Change-Id: I1456611222c24290f259298e883ca89dd830c74b
Prateek Saxena [Fri, 24 Mar 2017 11:39:07 +0000 (17:09 +0530)]
mw.widgets.Complex*: Add setDisabled
These widgets inherit from OO.ui.Widget and so need to implement
setDisabled. Calling this method right now would set the right
CSS classes but wont actually disable the widget.
Change-Id: I6747f4e64dd81197bb3e37c09876399f1cb3be07
Matthew Flaschen [Fri, 24 Mar 2017 01:07:38 +0000 (21:07 -0400)]
RC Filters docs: Directly mention group classes
Directly mention ChangesListBooleanFilterGroup and
ChangesListStringOptionsFilterGroup so people know what to construct.
Change-Id: I3c105d072889c1da26f94402326ba48635081833
jenkins-bot [Thu, 23 Mar 2017 23:37:43 +0000 (23:37 +0000)]
Merge "SpecialAllMessages: Remove unused variable langcode"
jenkins-bot [Thu, 23 Mar 2017 21:37:38 +0000 (21:37 +0000)]
Merge "Tweak figure styles based on visual diff testing"
Translation updater bot [Thu, 23 Mar 2017 21:06:14 +0000 (22:06 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id631b382683ce4ac3ef648bdb546821c74a9985c
jenkins-bot [Thu, 23 Mar 2017 21:04:09 +0000 (21:04 +0000)]
Merge "Follow-up Improve sorting on SpecialWanted*-Pages"
jenkins-bot [Thu, 23 Mar 2017 18:40:29 +0000 (18:40 +0000)]
Merge "ResourceLoaderImage: Point to the right skin when generating URL"
jenkins-bot [Thu, 23 Mar 2017 18:39:52 +0000 (18:39 +0000)]
Merge "ResourceLoaderOOUIImageModule: Actually load non-default themes' images"
Eddie Greiner-Petter [Wed, 22 Mar 2017 20:11:11 +0000 (21:11 +0100)]
Follow-up Improve sorting on SpecialWanted*-Pages
Change the SpecialWanted*-Pages so that they do sort
1. by the number of links to a site (as is now) and
2. alphabetically for entries which have the same number of links (new)
This is a follow-up for commit
5b15728.
The previous patch was reverted because using getOrderFields and
prefixing each order field with qc_ in fetchFromCache threw DB errors in
production. This follow-up differs in introducing a new function
getCacheOrderFields that defines order fields only for fetching from the
cache and doesn't reuse getOrderFields which is for the raw query
(without cache). It returns ['value'] by default and thus keeps the
known behaviour.
Bug: T4335
Change-Id: Ic01a3c28892c78ba9a9f0a7d665937efe87b44bd
jenkins-bot [Thu, 23 Mar 2017 18:25:21 +0000 (18:25 +0000)]
Merge "RCFilters: Only show filter capsule as conflicted if it's selected"
Moriel Schottlender [Thu, 23 Mar 2017 18:03:56 +0000 (11:03 -0700)]
RCFilters: Only show filter capsule as conflicted if it's selected
Bug: T161172
Change-Id: Ib15ffd58290c616de216178cee6ae9b86178d871
Brad Jorsch [Tue, 21 Mar 2017 12:42:52 +0000 (08:42 -0400)]
Decode '0'-valued user options to integer 0
I13d0e402f fixed a MySQL strict-mode bug by having boolean false be
sent to the database as 0 rather than "", since so many of our
logically-boolean fields are typed as tinyints. That happened to also
cause logically-false user preferences to be stored in the
user_properties table as "0" rather than "", which works fine in PHP but
confuses JavaScript since it considers string-0 as truthy rather than
falsey.
To avoid this situation, convert "0" to 0 when loading the user
options. Completely solving T54542 is left for another time, since
identifying which type to normalize each option to seems nontrivial.
Change-Id: Ia3280b7ce923641eac077141b47cba10d3fb88db
jenkins-bot [Thu, 23 Mar 2017 11:13:23 +0000 (11:13 +0000)]
Merge "RCFilters UI: Pass in userId to ChangesListHighlights schema"
jenkins-bot [Thu, 23 Mar 2017 04:15:52 +0000 (04:15 +0000)]
Merge "RemexCompatMunger: fix a couple of memory leaks"
jenkins-bot [Thu, 23 Mar 2017 03:40:24 +0000 (03:40 +0000)]
Merge "Update RemexHtml to 1.0.1"
Eddie Greiner-Petter [Tue, 21 Mar 2017 15:34:32 +0000 (16:34 +0100)]
Add MusikAnimal to CREDITS
Ran maintenance/updateCredits.php which determines new contributors
using git log. Found 1.
Change-Id: I0d3a2626051ca058ea391c39550d4c1d19f4f133
Tim Starling [Thu, 23 Mar 2017 01:50:14 +0000 (12:50 +1100)]
RemexCompatMunger: fix a couple of memory leaks
Change-Id: I47578b3f73320e84a157417c288de97b5d26e18f
Tim Starling [Thu, 23 Mar 2017 01:47:38 +0000 (12:47 +1100)]
Update RemexHtml to 1.0.1
For a bug fix
Depends-On: I4421afbfa52d7711d9369398891e91ae09db50c9
Change-Id: I5285c0b1c6f42891c002637cd3e4bd2f54615940
Roan Kattouw [Wed, 22 Mar 2017 22:08:12 +0000 (15:08 -0700)]
RCFilters UI: Pass in userId to ChangesListHighlights schema
Bug: T160928
Depends-On: Ia2bc679e37deb34b215ad16dfc3b8cfefdc8365c
Change-Id: I9d3f9281c2681ab1c89676234ddd544f76f3dc7f
jenkins-bot [Wed, 22 Mar 2017 21:18:19 +0000 (21:18 +0000)]
Merge "Allow extensions to add jQueryMsg magic words"
Translation updater bot [Wed, 22 Mar 2017 21:02:54 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I83074d7d6edd5cf2e3b69d0bb2382012a5b4e438
jenkins-bot [Wed, 22 Mar 2017 19:30:35 +0000 (19:30 +0000)]
Merge "RCFilters UI: Make the 'no results' message bold"
jenkins-bot [Wed, 22 Mar 2017 19:28:29 +0000 (19:28 +0000)]
Merge "RCFilters: Normalize overlay font-size for Monobook"
Matthew Flaschen [Wed, 22 Mar 2017 06:09:48 +0000 (02:09 -0400)]
Allow extensions to add jQueryMsg magic words
Change-Id: Ie82a147ff32ccda3f757108474f5cbab71d45ace
jenkins-bot [Wed, 22 Mar 2017 16:32:01 +0000 (16:32 +0000)]
Merge "Stop declaring ImageHistoryPseudoPager props dynamically"
addshore [Wed, 22 Mar 2017 12:21:24 +0000 (12:21 +0000)]
Stop declaring ImageHistoryPseudoPager props dynamically
The 3 properties declared here were introduced in:
0ca92d0bf5dd4e71b678d373a1beb3089d16a866
Change-Id: Ibbd0a86f02ab010720446db1aa2dc9ea0eb05aef
jenkins-bot [Wed, 22 Mar 2017 14:46:45 +0000 (14:46 +0000)]
Merge "Fix log msg param in UploadFromUrl::saveTempFileChunk"
jenkins-bot [Wed, 22 Mar 2017 14:43:55 +0000 (14:43 +0000)]
Merge "Mark public methods as public in ImageHistoryPseudoPager"
jenkins-bot [Wed, 22 Mar 2017 14:40:37 +0000 (14:40 +0000)]
Merge "Bugzilla -> Phab task number in $wgUrlProtocols phpdoc"
jenkins-bot [Wed, 22 Mar 2017 13:17:46 +0000 (13:17 +0000)]
Merge "Fix undefined ExternalStore::decompressRevisionText"
Andre Klapper [Wed, 22 Mar 2017 12:16:19 +0000 (13:16 +0100)]
Check for string initialization in ucfirst() to make HHVM 3.18 happy
Bug: T161095
Change-Id: I45b5d9e819061f443d4342c004bad80bd87c2a17
addshore [Wed, 22 Mar 2017 12:16:00 +0000 (12:16 +0000)]
Mark public methods as public in ImageHistoryPseudoPager
Change-Id: Iad4442d87df683daca978fa95068f9ca5221d8a5
Paladox [Wed, 22 Mar 2017 11:16:11 +0000 (11:16 +0000)]
Fix undefined ExternalStore::decompressRevisionText
make ExternalStore::decompressRevisionText self::decompressRevisionText
Change-Id: I3dc7317550f47e7e94d1403d3861d1059c7af6c9
addshore [Wed, 22 Mar 2017 10:39:46 +0000 (10:39 +0000)]
Fix log msg param in UploadFromUrl::saveTempFileChunk
$this->nbytes does not exist and is never written to.
It is probably intended that this uses the local $nbytes.
Change-Id: I8e923a27625d04c81b2e272a597d40d59397851f
addshore [Wed, 22 Mar 2017 10:02:55 +0000 (10:02 +0000)]
Bugzilla -> Phab task number in $wgUrlProtocols phpdoc
Change-Id: I1478ece1691d0b86aeae272dd041425eac4ed960